Skip to content

WIP: pure python #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

WIP: pure python #274

wants to merge 14 commits into from
+400 −60,545

Conversation

@joshmoore
Copy link
Member

@joshmoore joshmoore commented Feb 18, 2021

Following on from #259 (comment), I dropped the blosc module and am slowly making changes in the background to use native blosc wheels, turning this into a pure Python module. If anyone would like to add commits, please feel free (especially if you know what you are doing unlike myself...)

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py39 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

@joshmoore
Remove c-blosc submodule
5b3e230
@joshmoore
Remove extension code and build
e6bace0
@joshmoore
Temporary changes for testing on mac
fe5f51a
@joshmoore
Initial changes for getting tests passing
a4f85c1
@joshmoore
Disable tests for missing functionality
dfd20f5 
 * snappy: not compiled into wheel by default
 * decompress_partial: needs implementing
 * AUTOSHUFFLE: needs implementing
@joshmoore
Add a replacement blosc.py
5a179ed 
Unfortunately, this wasn't immediately put under revision control
and has undergone a number of changes. Original versions were largely
lifted out of blosc.pyx.
@pep8speaks
Copy link

pep8speaks commented Feb 18, 2021 •
edited
Loading

Hello @joshmoore! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:34: E203 whitespace before ':'
Line 13:35: E231 missing whitespace after ':'
Line 13:39: E252 missing whitespace around parameter equals
Line 13:40: E252 missing whitespace around parameter equals

Comment last updated at 2021-02-18 15:13:38 UTC

@joshmoore joshmoore force-pushed the pure-py branch 2 times, most recently from fd05e21 to 48b277b Compare February 18, 2021 14:21
@pbranson pbranson mentioned this pull request Feb 20, 2021
Closed
2 tasks
This was referenced Jul 28, 2021
Closed
Closed
@joshmoore joshmoore mentioned this pull request Aug 3, 2021
Merged
7 tasks
@danieldjewell danieldjewell mentioned this pull request Aug 5, 2021
Merged
7 tasks
@emiliom emiliom mentioned this pull request Jan 19, 2022
Closed
@joshmoore joshmoore mentioned this pull request Sep 25, 2023
Open
@normanrz
Copy link
Member

normanrz commented Jun 25, 2024

I wonder if we should close this PR? There is been very little progress in a long time.
Additionally, in my view the main value proposition of numcodecs is the distribution of built wheels for the various codecs. If we drop that, I would argue that zarr-python should depend on the upstream codec libraries (e.g. blosc, cramjam) directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshmoore @pep8speaks @normanrz